Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: improve the compatibility with mysql when datatime is invalid. (#11445) #11447

Merged
merged 10 commits into from
Jul 30, 2019
Merged

expression: improve the compatibility with mysql when datatime is invalid. (#11445) #11447

merged 10 commits into from
Jul 30, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jul 25, 2019

cherry-pick #11445 to release-3.0

@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 25, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Jul 25, 2019
Merged
@sre-bot sre-bot added component/expression contribution This PR is from a community contributor. type/3.0 cherry-pick type/bugfix This PR fixes a bug. labels Jul 25, 2019
zz-jason
zz-jason reviewed Jul 25, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested a review from SunRunAway July 25, 2019 11:20
@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 25, 2019
SunRunAway
SunRunAway approved these changes Jul 28, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 28, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 28, 2019

@sre-bot merge failed.

@SunRunAway
Copy link
Contributor

/run-all-tests tikv=release-3.0 pd=release-3.0 tidb-test=release-3.0

@SunRunAway
Copy link
Contributor

@wshwsh12 PTAL at CI problem.

@wshwsh12
Copy link
Contributor

/run-all-tests

@zz-jason
Copy link
Member

/run-all-tests

@zz-jason zz-jason removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 30, 2019
@zz-jason zz-jason merged commit c71adf9 into pingcap:release-3.0 Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sre-bot @SunRunAway @wshwsh12 @zz-jason @ono-yoko @ngaut